[release/10.0] Backport FormsInputDateTest fixes - #68124
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backports fixes to FormsInputDateTest on release/10.0 to make the WASM E2E tests deterministic by ensuring keyboard input starts at the left-most segment of native date/time inputs and by using a more robust clear-and-type sequence.
Changes:
- Un-quarantines the three failing WASM E2E tests and removes the now-unused
Microsoft.AspNetCore.InternalTestingimport. - Introduces
SetDate/ClearDatehelpers to position the caret and reliably clear native inputs before sending keys. - Fixes a typo in a comment (“Stricly” → “Strictly”).
Suppressed comments (1)
src/Components/test/E2ETest/Tests/FormsInputDateTest.cs:240
SetDatehard-codes threeKeys.ArrowLeftconcatenations. This is harder to tweak/read than the existing pattern in this file that usesEnumerable.Repeat/string.Concatfor repeated arrow keys.
input.Click();
input.SendKeys(Keys.ArrowLeft + Keys.ArrowLeft + Keys.ArrowLeft);
input.SendKeys(keys);
Youssef1313
approved these changes
Aug 3, 2026
ilonatommy
added
Servicing-approved
Contributor
|
Hi @ilonatommy. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #68107 and #68115 to release/10.0
Fixes #67650.
Description
The caret has to be located over the left-most segment of the 3-segment date input, otherwise
SendKeyswill write to wrong segment, producing non-desired date values.The test fails deterministically before fix and passes deterministically after the fix.
Customer Impact
None, it's just a test.
Regression?
Risk
Test fix.
Verification
Packaging changes reviewed?